-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sl rn saved queries w no exports #6798
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
## January 2025 | ||
|
||
- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports don't fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports don't fail. | |
- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error, due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports, don't fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @nataliefiann ! not sure if we need the commas here and i wonder if it actually disrupts the flow. the clause "don't fail" is directly linked to the preceding phrase so it looks like the comma interrupts it. how about adding a comma after the 'Exports are optional, and this...:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to commit it with the: 'Exports are optional, and this...' but please let me know if you have any strong feelings about this version! thank yoU!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
Thanks for creating this! I've approved this for you and left 2 non-block suggestions (jut 2 commas to break up the sentence).
Kind Regards
Natalie
this pr adds a SL release note entry that adds a fix made to ensure saved queries w no exports don't fail
linear: https://linear.app/dbt-labs/issue/SL-3174/add-support-for-multiple-time-spines-when-using-deferral-in-mantle
🚀 Deployment available! Here are the direct links to the updated files: