Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sl rn saved queries w no exports #6798

Merged
merged 3 commits into from
Jan 20, 2025
Merged

sl rn saved queries w no exports #6798

merged 3 commits into from
Jan 20, 2025

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jan 20, 2025

this pr adds a SL release note entry that adds a fix made to ensure saved queries w no exports don't fail

linear: https://linear.app/dbt-labs/issue/SL-3174/add-support-for-multiple-time-spines-when-using-deferral-in-mantle


🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner January 20, 2025 12:59
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 20, 2025 1:22pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Jan 20, 2025
## January 2025

- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports don't fail.
Copy link
Contributor

@nataliefiann nataliefiann Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports don't fail.
- **Fix**: Fixed an issue where [saved queries](/docs/build/saved-queries) with no [exports](/docs/build/saved-queries#configure-exports) would fail with an `UnboundLocalError`. Previously, attempting to process a saved query without any exports would cause an error, due to an undefined relation variable. Exports are optional and this fix ensures saved queries without exports, don't fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nataliefiann ! not sure if we need the commas here and i wonder if it actually disrupts the flow. the clause "don't fail" is directly linked to the preceding phrase so it looks like the comma interrupts it. how about adding a comma after the 'Exports are optional, and this...:

Copy link
Contributor Author

@mirnawong1 mirnawong1 Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to commit it with the: 'Exports are optional, and this...' but please let me know if you have any strong feelings about this version! thank yoU!

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this! I've approved this for you and left 2 non-block suggestions (jut 2 commas to break up the sentence).

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit 0458e50 into current Jan 20, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the sl-rn-jan branch January 20, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants